On Tue, 23 Dec 2025 23:32:19 GMT, Kevin Rushforth <[email protected]> wrote:
>> I'll take a look at this as well. >> >> One thing I do note is that it might be helpful if this doc clarification >> had a separate doc issue to track it -- even if it goes in as part of this >> PR -- since it is independent from what is otherwise a preview feature. > > In thinking about this further, I recommend to separate out any changes that > are not specific to the HeaderBar preview feature (i.e., revert the changes > in this file for this PR). Then file a new "doc bug" to better clarify the > terms "left" and "right" in the presence of RTL. In general it's best not to > mix changes to a preview feature with more global changes unless there is a > compelling need (there isn't here). From a practical point of view, it will > make it more likely to get this in for JavaFX 26 prior to RDP1 if the changes > are limited to the preview feature at hand. The doc changes can still go in > for 26 during rampdown. I've reverted the changes to this file. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1936#discussion_r2644820775
