On Thu, 12 Mar 2026 13:20:31 GMT, Dmitry Markov <[email protected]> wrote:

>> Documented the IllegalArgumentException thrown when the initial directory 
>> was invalid, and improved the exception description to be more precise and 
>> informative.
>
> Dmitry Markov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add fall back to platform-default location

The implementation and updated docs look good with one suggested change in the 
docs.

modules/javafx.graphics/src/main/java/javafx/stage/FileChooser.java line 209:

> 207:      * The initial directory for the displayed file dialog.
> 208:      * <p>
> 209:      * If this directory is not set, does not exist, is not a directory 
> or is not accessible,

Can you add a comma between "directory" and "or is not"? We use the Oxford 
(serial) comma in JavaFX docs.

-------------

PR Review: https://git.openjdk.org/jfx/pull/2101#pullrequestreview-3936709721
PR Review Comment: https://git.openjdk.org/jfx/pull/2101#discussion_r2924739142

Reply via email to