On Thu, 12 Mar 2026 14:57:59 GMT, Dmitry Markov <[email protected]> wrote:

>> Documented the IllegalArgumentException thrown when the initial directory 
>> was invalid, and improved the exception description to be more precise and 
>> informative.
>
> Dmitry Markov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Added Oxford comma

I suppose referring to platform specific directory is good enough (we can't be 
responsible for what the platform does).  

Case in point: running the reproducer on my machine shows up the dialog 
pointing to some completely unrelated directory (not a `user.home`)  It appears 
macOS associates the previously used directory with the launching program.

Anyway, looks good to me, this is a good improvement.

Thank you everyone for a good discussion!  That was the fastest we all came to 
the same conclusion :-)

Please update this PR description.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2101#pullrequestreview-3937817544
PR Comment: https://git.openjdk.org/jfx/pull/2101#issuecomment-4047923655
PR Comment: https://git.openjdk.org/jfx/pull/2101#issuecomment-4047932198

Reply via email to