On Thu, 12 Mar 2026 14:57:59 GMT, Dmitry Markov <[email protected]> wrote:

>> Documented the IllegalArgumentException thrown when the initial directory 
>> was invalid, and improved the exception description to be more precise and 
>> informative.
>
> Dmitry Markov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Added Oxford comma

modules/javafx.graphics/src/main/java/com/sun/glass/ui/CommonDialogs.java line 
235:

> 233:                 return folder.getCanonicalPath();
> 234:             } catch (IOException e) {
> 235:                 // Do not propagate the exception and let the platfrom 
> decide

Minor: The comment can probably be put in the same line

modules/javafx.graphics/src/main/java/com/sun/glass/ui/CommonDialogs.java line 
236:

> 234:             } catch (IOException e) {
> 235:                 // Do not propagate the exception and let the platfrom 
> decide
> 236:                 // what folder to use as initial dirictory.

typo: `directory`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2101#discussion_r2925706940
PR Review Comment: https://git.openjdk.org/jfx/pull/2101#discussion_r2925708075

Reply via email to