On Wed, 25 Mar 2026 18:53:41 GMT, Christopher Schnick <[email protected]> 
wrote:

>> Thanks for confirming. Yeah agree, that looks wrong.
>
> Looking at the code review for the commit that caused this, that is a perfect 
> example of how diffs can mislead. The fact that it introduced dead code was 
> not visible from the diffs, only if you looked at the whole context.

And I even made a (IMO good) suggestion to improve the if condition 🙂
-> I made this comment because I felt like the if-else condition is confusing. 
So turns out, it is.

I would therefore recommend to improve it now and remove the else block. It is 
empty anyway.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2128#discussion_r2990379862

Reply via email to