On Wed, 25 Mar 2026 18:49:07 GMT, Christopher Schnick <[email protected]> wrote:
>> This fixes a regression caused by the fix for >> https://bugs.openjdk.org/browse/JDK-8282290 > > Christopher Schnick has updated the pull request incrementally with two > additional commits since the last revision: > > - Adjust tests > - Adjust tests Looks like the problem is fixed on macOS, but it should be tested on Windows at fractional scales (I suspect the fix is not exactly right for fractional scales). Also, it would help to provide a bit more information about the fix in the PR description (explain the change). modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java line 257: > 255: > 256: if (caretPath.getElements().size() != 0) { > 257: caretWidth = > Math.round(caretPath.getLayoutBounds().getWidth()); I wonder if this should be `Region.snapSizeX()` instead of `Math.round()`: not only Math.round() may round downward, but also produce mid-pixel results on systems with fractional scale. Can you double check it on Windows at fractional scales (125%, 150%, 175%, 225%)? ------------- PR Review: https://git.openjdk.org/jfx/pull/2128#pullrequestreview-4015258771 PR Review Comment: https://git.openjdk.org/jfx/pull/2128#discussion_r2995845996
