On Thu, 26 Mar 2026 16:30:16 GMT, Christopher Schnick <[email protected]> wrote:
>> Since `caretWidth` is not directly used here, but rather in other code to >> calculate the translation or related, it is very likely fine here, but the >> target values in the other calculations may need to be snapped. > > The caretWidth value is included in various calculations, and the results of > those are snapped. So I think this works correctly. This PR just restores the > old behaviour before it was broken. > > I will check on Windows for various scales Ok so Andy was right, the caret is sometimes still hidden on the right on different display scales. But even snapping the caret width does not always fix it. It requires a bigger fix for the skin in general. However, I would argue that this is a different issue unrelated to this. I could open a follow-up to make the TextFieldSkin handle the display scale properly ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2128#discussion_r2997330664
