On Wed, 13 May 2026 18:11:42 GMT, Andy Goryachev <[email protected]> wrote:

> I like this idea very much (will do more testing).
> 
> Do you think these tickets are related or similar:

I looked into several of these and even prototyped some fixes. The problems 
with ESCAPE and ENTER being consumed are at a higher level. For example, in 
some case the InputMaps are auto-consuming ESCAPE when it should be consumed 
conditionally.

This PR deals with the way ComboBox and Spinner re-fire events. Some of the bug 
reports mention event re-firing but I think those might be obsolete. There's 
comments in the code suggesting TextEdits used to re-fire ESCAPE at their 
parents but I don't think that's happening anymore.

> Also, I wonder if other virtualized controls with embedded editors such as 
> `ListView`, `Tree|TableView` might benefit from this fix?

I'm not familiar with those controls but as far as I know they don't re-fire 
KeyEvents to drive their editors. I think they set focus directly on their 
editors when editing in which case this fix isn't relevant. Some quick testing 
seems to confirm this; they process shortcuts like Cmd+Q just fine.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2166#issuecomment-4444831934

Reply via email to