On Mon, 18 May 2026 20:41:59 GMT, Andy Goryachev <[email protected]> wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into combospinnernofire
>> - Moved event dispatch to utility method in EventUtil.
>> - Clean up based on review feedback
>> - Only run tests on Mac
>> - New approach to forwarding key events to ComboBox and Spinner editors
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxPopupControl.java
> line 617:
>
>> 615: ke.consume();
>> 616: } else if (textField != null) {
>> 617: forwardToTextField(ke);
>
> Should the `ke` event be consumed if its copy was consumed?
My policy is to preserve the old logic as much as possible. There's a bunch of
tricky code related to handling ENTER and ESCAPE that I don't want to disturb.
In this case the event is KEY_RELEASED for ENTER. I'm pretty sure the TextField
will ignore it and it will never be consumed anyway.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2166#discussion_r3267504872
