On Mon, 18 May 2026 20:14:05 GMT, Andy Goryachev <[email protected]> wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into combospinnernofire
>> - Moved event dispatch to utility method in EventUtil.
>> - Clean up based on review feedback
>> - Only run tests on Mac
>> - New approach to forwarding key events to ComboBox and Spinner editors
>
> modules/javafx.base/src/main/java/com/sun/javafx/event/EventUtil.java line 78:
>
>> 76: }
>> 77:
>> 78: public static Event dispatch(Event event, EventDispatcher
>> dispatcher) {
>
> would it make sense to pass the `Node` instead of the dispatcher, and return
> a `boolean`?
EventUtil is in the javafx.base module and doesn't have access to Node.
Dispatching an event returns an event (possibly null) and all other routines in
EventUtil return that event. It strikes me as artificial to only check whether
the event was consumed or not.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2166#discussion_r3261948238
