On Tue, 19 May 2026 08:41:23 GMT, Michael Strauß <[email protected]> wrote:
> and all questions have been answered. they weren't, I was waiting for your response (not the first time, I might add). But you do bring a good point - we should indicate more clearly that the discussion is not over. My understanding is that all who substantially participated in the review (or raised substantial concern) need to mark a PR as Approved, or explicitly say that a change is requested. Also, if there is no response for some time, we usually add a comment. `<rant>` Gitlab has explicit [Resolve Thread] button, but in github this button seem to work backwards: the originator of the comment _cannot_ resolve the discussion. I've started to use emoji to indicate the acquiescence, but it is a low key indicator. Collapsing a discussion is also not very user-friendly, since often other participants have input too. Oh well, time to go through the open PRs and check for unresolved discussions. `</rant>` ------------- PR Comment: https://git.openjdk.org/jfx/pull/2091#issuecomment-4488875971
