On Mon, 18 May 2026 18:38:48 GMT, Michael Strauß <[email protected]> wrote:

> The same reentrant call could also have happened with the old implementation

The old code used `String` for a key, which is perfectly re-entrant.

But, after a closer look, your peerCacheKey is only used to lookup once, more 
importantly, no other code can intervene between the key is mutated and the 
cached value is returned.  _Unless someone changes it later_, this should be 
fine.

I am a bit concerned though that you integrated this PR without reaching 
agreement on all the comments first.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2091#issuecomment-4480924511

Reply via email to