On Mon, 2 Mar 2026 22:14:15 GMT, Michael Strauß <[email protected]> wrote:
>> The current implementation of `Renderer.getPeerInstance()` looks up mappings >> by concatenating strings to form a combined key: >> >> peer = peerCache.get(name + "_" + unrollCount); >> >> >> This can be improved by not using strings to store the combined key, but >> using a simple `PeerCacheKey` class instead. >> The `Renderer` class then uses a single reusable `PeerCacheKey` object to >> look up mappings, making the lookup allocation-free. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > review comment > Can you guarantee that this code will never be re-entered? If so, maybe add a > comment pointing to this requirement? edit: too late for this Pr obviously, > maybe in JDK-8384870 then? > > (re: reentrancy, see #1691 ) I'm quite confident that this didn't structurally introduce a _new_ race condition. If there is one, it was already there before. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2091#issuecomment-4479656436
