On Wed, 17 Jun 2026 22:00:30 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change "since" javadoc tag to 27
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line
> 370:
>
>> 368: */
>> 369: public static double getSystemButtonHeight(Stage stage) {
>> 370: return AttachedProperties.of(stage).systemButtonHeight.get();
>
> side node: if we decide to put rarely used properties in a hashtable (see
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Experiments/NodeProperties.md
> ) we could get rid of the `AttachedProperties` machinery (or roll it into
> the `NodeProperties`).
Yes, attached properties shouldn't be stored in `Node.getProperties()` at all,
where they are publicly accessible and can also be changed or removed by
completely unrelated code.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2188#discussion_r3431806524
