On Thu, 18 Jun 2026 15:06:06 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use read-only wrappers
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacWindow.java
> line 53:
>
>> 51: if (isExtendedWindow()) {
>> 52:
>> headerButtonHeightProperty().subscribe(this::onHeaderButtonHeightChanged);
>> 53:
>> headerButtonDarkStyleProperty().subscribe(this::onHeaderButtonDarkStyleChanged);
>
> question: here we bind to the `headerButtonDarkStyleProperty`, but in
> `GtkWindow` and `WinWindow` we do not. Is this right?
It's bound in `WinWindow.createHeaderButtonOverlay()`, but not in
`GtkWindow.createHeaderButtonOverlay()`. Good catch!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2188#discussion_r3437008881
