On Thu, 18 Jun 2026 14:55:59 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use read-only wrappers
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/SceneContext.java
> line 130:
>
>> 128: @Override
>> 129: protected void onInvalidated() {
>> 130: if (scene.getWindow() instanceof Stage stage) {
>
> question: if the Scene had the colorScheme property set before it's added to
> a Stage, will the stage color scheme be updated correctly?
Yes, the actual scene color scheme is queried unconditionally just before the
stage is shown in `Stage.isHeaderButtonDarkStyle()`. The
`StageHelper.notifyColorSchemeChanged()` path is only relevant if the scene
color scheme is changed while the stage is showing.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2188#discussion_r3436978093
