On Thu, 2 Jul 2026 15:15:24 GMT, Andy Goryachev <[email protected]> wrote:
>> Petr Štechmüller has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Use collection instead of List/Set pair
>> - Update copyright headers
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 486:
>
>> 484: String stringValue) throws LoadException {
>> 485: // Split the string and add the values to the list
>> 486: List<Object> list =
>> (List<Object>)valueAdapter.get(listPropertyName);
>
> should it be `Collection<Object>` ?
I see this as a one special case. This is designed specifically for handling
coma separated values and based on the type where it will be assigned it use
`Array` or a `List`.
So in my opinion I would leave this untouched.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3514583782
