On Thu, 2 Jul 2026 15:38:05 GMT, Andy Goryachev <[email protected]> wrote:
>> Petr Štechmüller has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Use collection instead of List/Set pair
>> - Update copyright headers
>
> modules/javafx.fxml/src/main/java/com/sun/javafx/fxml/builder/ProxyBuilder.java
> line 211:
>
>> 209: }
>> 210: if (Collection.class.isAssignableFrom(retType)) {
>> 211: return new ArrayListWrapper<>();
>
> should it be called `CollectionWrapper` ?
>
> or, why have this type at all - the `Set` case returns a `LinkedHashSet`
> instance, so perhaps this case should return `LinkedList` maybe?
Maybe something we could check in a follow up?
If I understand the author correctly, it is not 100% clear if this is needed or
not
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3550061792
