On Mon, 7 Sep 2026 13:14:41 GMT, Marius Hanl <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - change the way we process a stale CssStyleHelper >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> >> # Conflicts: >> # >> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> - 8388277: [REDO] Looked-up color fails for -fx-background-color in JavaFX >> CSS file > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 230: > >> 228: >> 229: private static Styleable[] styleablePath(Styleable styleable) { >> 230: Styleable[] path = new Styleable[8]; > > I wonder if a `List` makes more sense. So open for opinions, I used an array > as we also do that with e.g. `triggerStates` and to squeeze out a bit of > performance. But not sure if it is worth it. A `List` might be a better option as it avoids growing the array manually, enables streams ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2225#discussion_r3972863342
