On Wed, 9 Sep 2026 23:49:07 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix another broken case
>
> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line
> 100:
>
>> 98: // We first recreate the style helper that are stale.
>> 99: // This usually only happens when a child changes the scene tree
>> while its CSS is processed.
>> 100: for (int index = path.length - 1; index > 0; index--) {
>
> so my ai buddy suggests the process remains quadratic:
> while `getStyleableParent()` is used only once, its overloads are called for
> each stale ancestor. each scans the path to find a user-set font, following
> to the root, and a new `CacheContainer` scans again.
I fail to understand that. All methods in the `createStyleHelper` will use the
parent chain we created once. How could we still end up being quadratic? We
will go through the aprent chain, yes, but we did that before as well
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2225#discussion_r3974243434
