On Wed, 9 Sep 2026 23:37:10 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another broken case > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 104: > >> 102: ancestor.cssHelperStale = false; >> 103: ancestor.cssHelperResolvedEarly = true; >> 104: ancestor.styleHelper = createStyleHelper(ancestor, >> path, index); > > `cssHelperStale` is reset before the the new helper is created, which will > cause problems if the new helper resets css properties, invoking listeners. > if such a listener styles another descendant, or adds another descendant, the > CSS code will see `cssHelperStale=false` but observe the old helper instance. > > we might want to consider either a "resolving" state or detect this condition > and retry. Not sure I understand. Why would it do that? We just create it and move on. No other method is called. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2225#discussion_r3974209391
