On Fri, 11 Sep 2026 13:40:58 GMT, Marius Hanl <[email protected]> wrote:

>> Improved the manual test instructions and pass/fail criteria for the 
>> following tests :
>> 
>> - NotResizableWindowTest
>> - DndBasic
>> - DndTestDragViewRawImage
>> - PrintDialogModalityTest
>> - PrintOrientTest
>> - StartIconified
>> - DragDropFromSwingComponentInSwingNodeTest
>> - DragDropOntoJavaFXControlInJFXPanelTest
>> - EmojiTest
>> - EventListenerLeak
>> - InputTypeAcceptAttributeTest
>> - GifImageTestApp
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> tests/manual/printing/PrintOrientTest.java line 109:
> 
>> 107:         Button print = new Button("Print");
>> 108:         print.setLayoutX(80);
>> 109:         print.setLayoutY(300);
> 
> Setting a manual layout is almost always a bad idea, usually just using a box 
> and alignment is better

This ticket is for instructions changes only and the only reason why I changed 
the layout was because the button was hiding some instructions. I will keep 
this change for another ticket.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4041505973

Reply via email to