On Fri, 18 Sep 2026 17:23:00 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Improved the manual test instructions and pass/fail criteria for the >> following tests : >> >> - NotResizableWindowTest >> - DndBasic >> - DndTestDragViewRawImage >> - PrintDialogModalityTest >> - PrintOrientTest >> - StartIconified >> - DragDropFromSwingComponentInSwingNodeTest >> - DragDropOntoJavaFXControlInJFXPanelTest >> - EmojiTest >> - EventListenerLeak >> - InputTypeAcceptAttributeTest >> - GifImageTestApp >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor instruction change to PrintOrientTest tests/manual/swing/DragDropFromSwingComponentInSwingNodeTest.java line 86: > 84: > 85: VBox rootNode = new VBox(6, > 86: new Label(""" minor: the formatting of the text blocks in this PR is all over the place. tests/manual/swing/DragDropOntoJavaFXControlInJFXPanelTest.java line 123: > 121: hBox1.getChildren().add(textField); > 122: VBox rootNode = new VBox(6, hBox1, > 123: new Label("1. This is a test for drag / drop > onto a JavaFX control in a JFXPanel.\n" + this can use a text block instead of string concatenation. tests/manual/text/EmojiTest.java line 64: > 62: Press the Pass or Fail button as appropriate, and the test > will exit. > 63: If what you see is not explained here, ask before filing a > bug. > 64: """; FYI: I've used this test in #2156 I've updated my copy to use the same text for now, though I find the instructions to be too verbose. Basically, what's needed is explanation 1. what to do 2. exact criteria for passing (or failing) I'd like to take this in a follow-up to migrate existing manual tests after #2156 gets integrated. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4049294259 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4049302430 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4049285015
