On Mon, 21 Sep 2026 18:04:44 GMT, Andy Goryachev <[email protected]> wrote:
>> tests/manual/dnd/DndBasic.java line 103: >> >>> 101: modifiers = >>> 102: "macOS: Use no modifier for COPY, 'Command' for >>> MOVE, " + >>> 103: "and 'Control+Option' for LINK."; >> >> On my macOS 15 system, netierh CMD+Option nor Control+Option will enable >> LINK. I tested this by dragging from the top box on the left to the top box >> on the right. The "Move" keyboard modifier works, but the "Link" doesn't >> work for me. > > control-option drop works for me on the LINK target. > > My issue with this test is that pass-fail criteria are not clear. there is a > wall of text that tries to explain things for various tests but I imagine the > testers will have hard time trying to parse that out. > > Instead, perhaps, the window should have a third column saying what the > tester should do in each case, and the exact pass (or fail) criteria for each > case. > > alternatively, since the tester is supposed to match text shown in the source > and target area, the test can do it by itself? > > also, we probably should have the test name in the title. I realized my complaints go way beyond simple "update instructions" task, so we could take it as a training exercise for the testers. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4065043718
