On Fri, 18 Sep 2026 17:23:00 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Improved the manual test instructions and pass/fail criteria for the >> following tests : >> >> - NotResizableWindowTest >> - DndBasic >> - DndTestDragViewRawImage >> - PrintDialogModalityTest >> - PrintOrientTest >> - StartIconified >> - DragDropFromSwingComponentInSwingNodeTest >> - DragDropOntoJavaFXControlInJFXPanelTest >> - EmojiTest >> - EventListenerLeak >> - InputTypeAcceptAttributeTest >> - GifImageTestApp >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor instruction change to PrintOrientTest A few mostly minor comments. The rest looks good. tests/manual/dnd/DndBasic.java line 114: > 112: also be used as either the drag source or the drop destination. > 113: The names inside each Source and Destination box show its > supported actions. > 114: An action is compatible when it appears in both boxes. This is better, but still a little unclear. Do I only drag between boxes on the same line or should I do all combinations of each box on the left dragged to every other box on the right? And when should I use the key modifiers? Only when there are multiple sources and I want to choose which? And do I need to do all combinations of modifiers? tests/manual/stage/StartIconified.java line 47: > 45: 1. The "Iconified Window Test" must initially appear only on > the > 46: operating-system taskbar or Dock. > 47: 2. It must not appear normally on the screen before becoming > iconified. Suggestion: 2. It must not appear normally on the screen before becoming iconified, even briefly. If it does, the test fails. tests/manual/stage/StartIconified.java line 67: > 65: Text text = new Text(""" > 66: 1. This stage must initially appear on the OS taskbar > (iconified), but not on the Screen > 67: 2. Observe if the stage pops and then iconifies > (wrong)"""); Suggestion: This stage must initially appear on the OS taskbar (iconified), but not on the Screen. Line 1 lets the tester knows that it must not show up initially. Good. Line 2 is already covered as part of the instructions for the first stage (I added a clarifying suggestion). ------------- PR Review: https://git.openjdk.org/jfx/pull/2315#pullrequestreview-5248213919 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4049383094 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4049933023 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4049902865
