On Tue, 6 Oct 2026 21:34:14 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ContextMenuTest.java >> line 69: >> >>> 67: import test.com.sun.javafx.scene.control.infrastructure.MouseEventFirer; >>> 68: import test.com.sun.javafx.scene.control.infrastructure.StageLoader; >>> 69: import test.javafx.scene.CssStyleHelperTest; >> >> this produces two errors in Eclipse: >> >> >> Description Resource Type Path Location >> CssStyleHelperTest cannot be resolved ContextMenuTest.java Java >> Problem /controls/src/test/java/test/javafx/scene/control line 733 >> The type test.javafx.scene.CssStyleHelperTest is not accessible >> ContextMenuTest.java Java Problem >> /controls/src/test/java/test/javafx/scene/control line 71 >> >> >> >> what bothers me here is that the `toDataURL()` method referred to should not >> be in a file called `CssStyleHelperTest` but maybe in `Utils`, and also that >> the are creating an inter-module dependency for tests. >> >> Is there a way to create a utility package accessible to all the modules >> where we can park all the little utility methods? Or do we have to >> duplicate this and similar methods across the modules? >> >> we also have two `CssStyleHelperTest` classes in graphics/src/test and >> tests/system > > yeah it should really just be copied into this class. I will (want to) > eventually improve the tests, but for now I was a bit scared due to > backports, so will probably make a mailing thread about it first. +1 for asking on the mailing list maybe we could have a dedicated utility class for tests in each module (`TestUtils`)? we'll have to tolerate some code replication. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2215#discussion_r4200688082
