On Tue, 6 Oct 2026 21:19:54 GMT, Andy Goryachev <[email protected]> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8388313: PR feedback1
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ContextMenuTest.java
> line 704:
>
>> 702: String css = """
>> 703: .button { -fx-skin:
>> "test.javafx.scene.control.ContextMenuTest$ButtonSkin1"; }
>> 704: .anchor .button { -fx-skin:
>> "st.javafx.scene.control.ContextMenuTest$ButtonSkin2"; }
>
> **st.** javafx.scene.control.ContextMenuTest$ButtonSkin2
> is this a typo?
yes, fixed.
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ContextMenuTest.java
> line 809:
>
>> 807: public ButtonSkin1(Button button) { super(button); }
>> 808: }
>> 809: public static class ButtonSkin2 extends ButtonSkin {
>
> please add a newline here
done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2215#discussion_r4208132726
PR Review Comment: https://git.openjdk.org/jfx/pull/2215#discussion_r4208126660
