> When ContextMenu.show(node, side, x, y) is executed, the CSS is evaluated 
> multiple times.
> Of these 3 times, 2 process a non-final CSS state.
> This leads to temporary, unnecessary changes.
> 
> This is fixed by properly defining the stylesheets and the 
> ownerWindow/ownerNode properties of the context menu
> before applyCss is called. The previous solution was incomplete and resulted 
> in unnecessary CSS calls.
> 
> Slightly related to my other PR: https://github.com/openjdk/jfx/pull/2213
> But it is fixed in a way that works independently of it.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Florian Kirmaier has updated the pull request incrementally with one additional 
commit since the last revision:

  8388313: PR feedback1

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2215/files
  - new: https://git.openjdk.org/jfx/pull/2215/files/1673def2..dddc56df

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2215&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2215&range=01-02

  Stats: 10 lines in 1 file changed: 7 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jfx/pull/2215.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2215/head:pull/2215

PR: https://git.openjdk.org/jfx/pull/2215

Reply via email to