On Wed, 21 Oct 2026 02:29:00 GMT, John Hendrikx <[email protected]> wrote:
>> This PR adds a `getDrawingContext` method to `WritableImage`, which works >> similar to `Canvas::getGraphicsContext` and shares the same signatures. Key >> features include: >> >> - **Shape rendering**: `strokeRect`, `fillRect`, `strokeOval`, `fillOval`, >> `strokeArc`, `fillArc`, `strokePolyline`, `fillPolygon`, etc. >> - **Stroke and fill attributes**: `lineWidth`, `lineCap`, `lineJoin`, >> `miterLimit`, `fillRule`, `stroke` and `fill` paints. >> - **Global graphics settings**: `globalAlpha` and `globalBlendMode`. >> - **Image drawing**: draw other `Image` instances with scaling and >> source/destination rectangles. >> - **Text rendering**: render text >> - **Save/Restore**: store current stroke, font, dashes, etc and restore them >> later >> - **Paths**: begin a path, with lines, curves, etc, then stroke or fill it >> - **Clips**: support rectangular clips in the SW renderer >> >> This feature enables direct software rendering to `WritableImage` without >> requiring a `Canvas` + snapshot. >> >> **New API for `GraphicsContext`** >> >> Because `GraphicsContext` was never designed to support a more generic API >> when it was conceived, it has gained a few new methods that were a better >> fit for the reusable `DrawingContext` interface: >> >> - `clipRect(x, y, w, h)` -- convenience equivalent to `rect(...)` + `clip()` >> - `getEffect()` -- no arg getter for the `Effect` >> - `getTextDirection()` and `setTextDirection(NodeOrientation)` -- takes >> precedence over `Canvas.getNodeOrientation()` when not set to `INHERIT` (the >> default) >> >> **Additional notes**: >> >> - The implementation leverages the software stack consisting of the Marlin >> rasterizer and Pisces compositor/painter. >> >> **Example usage**: >> >> >> WritableImage img = new WritableImage(400, 400); >> DrawingContext ctx = img.getDrawingContext(); >> ctx.setFill(Color.RED); >> ctx.fillRect(50, 50, 100, 100); >> >> >> See the sample program `RandomShapesDemo` to see a `WritableImage` and >> `Canvas` side by side performing the same operations: >> >> <img width="1249" height="741" alt="image" >> src="https://github.com/user-attachments/assets/4a0b9dcc-8f96-4faa-99cf-83c66d2c851e"; >> /> >> >> Newer version: >> >> <img width="1249" height="741" alt="image" >> src="https://github.com/user-attachments/assets/c0502620-3d02-4fbd-8c33-43bd5138b42c"; >> /> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > John Hendrikx has updated the pull request incrementally with eight > additional commits since the last revision: > > - Add fast no copy draw path for heap backed INT_ARGB images > - Document image size limitations > - Add test for malformed polygon data > - Fix new and pre-existing issue in JJavaSurface.c > - Document and align behavior when not enough points supplied for polygon > - Documented strokes/fills degenerate cases and made them consistent > - Add missing table entry for GraphicsContext > - Fix copyright year after botched merge modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java line 272: > 270: @Override > 271: public void run() { > 272: texture.dispose(); `SWRTTexture.dispose()` is a no-op. Are you sure all the native resources will be cleaned up? modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java line 1331: > 1329: // Use a compatible, array-backed image directly instead of > copying it > 1330: Texture tex = null; > 1331: boolean wrapped = false; minor: flip logic to avoid negation? (`boolean dispose`?) modules/javafx.graphics/src/main/java/javafx/scene/image/DrawingContext.java line 1172: > 1170: > 1171: /** > 1172: * Strokes an Arc using the current stroke paint. A {@code null} > ArcType will minor: "Strokes an arc" modules/javafx.graphics/src/test/java/test/com/sun/prism/sw/SWDrawingContextTest.java line 82: > 80: import test.com.sun.javafx.pgstub.StubToolkit; > 81: > 82: public class SWDrawingContextTest { Should this test verify pixels in all the test cases? At least make sure that one pixel was painted in each operation? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4340547177 PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4339490856 PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4339526883 PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4339588124
