On Wed, 21 Oct 2026 16:49:49 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with eight >> additional commits since the last revision: >> >> - Add fast no copy draw path for heap backed INT_ARGB images >> - Document image size limitations >> - Add test for malformed polygon data >> - Fix new and pre-existing issue in JJavaSurface.c >> - Document and align behavior when not enough points supplied for polygon >> - Documented strokes/fills degenerate cases and made them consistent >> - Add missing table entry for GraphicsContext >> - Fix copyright year after botched merge > > modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java > line 1331: > >> 1329: // Use a compatible, array-backed image directly instead of >> copying it >> 1330: Texture tex = null; >> 1331: boolean wrapped = false; > > minor: flip logic to avoid negation? (`boolean dispose`?) I don't think that would make it more readable. Instead, now just calling dispose unconditionally because no matter what the texture does, it can't affect a heap based array anyway (and it is a no-op for software textures so). Documented this a bit to make it clear. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4347080099
