On Wed, 21 Oct 2026 20:00:57 GMT, John Hendrikx <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java 
>> line 272:
>> 
>>> 270:         @Override
>>> 271:         public void run() {
>>> 272:             texture.dispose();
>> 
>> `SWRTTexture.dispose()` is a no-op.  Are you sure all the native resources 
>> will be cleaned up?
>
> There are no native resources for a software texture. It does point to the 
> data of the `WritableImage`, but that may outlive the `DrawingContext`, so 
> even if we could clean it up immediately, the largest chunk (the image) would 
> still live on as `WritableImage` refers it. So the `dipose` being empty is 
> correct for this kind of texture.

`PiscesRenderer`?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4352491106

Reply via email to