On Fri, 23 Oct 2026 15:21:17 GMT, Andy Goryachev <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
>>  line 729:
>> 
>>> 727:      * @return true, if only the runs can be reused
>>> 728:      */
>>> 729:     private boolean onlyReuseRuns() {
>> 
>> See: 
>> https://github.com/openjdk/jfx/pull/2145/files#diff-998e4e05957f324eac913749e4eabc7beb6fc49667344314f66354de68f97236
>> 
>> This could be tested in `TextLayoutUtilsContractTest.java`. Probably the 
>> very same way, so copy a test, change the tab width, and check the 
>> `glyphLayoutCreationCounter`.
>
> No it can't - needs the real `PrismLayout`.

Did you check the link even? `onlyReuseRuns` can be tested, which I did. This 
is what this comment is about.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2352#discussion_r4367993777

Reply via email to