On Mon, 26 Oct 2026 15:12:47 GMT, Andy Goryachev <[email protected]> wrote:
> Thank you for providing this test. I could add it to the suite, but it relies > on private specifics of the particular implementation. Yes, but thats good. If we want to e.g. improve caching in the future (or change when reuse runs, as example), this tests can help us catch regressions or test that indeed things are cached / new glyph layout is not created. > There were two reasons why I decided to create a system test which exercises > the real thing But thats not the topic here. As I said, you SHOULD keep the system test. I would have written one as well in this case. This is about having an additional unit test. And, again, when we may improve font rendering performance (which is not great) in JavaFX; those would come in handy. In this case, that they rely on the internal caching behavior is exactly what we need for tests in that area. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2352#discussion_r4379697303
