On Mon, 26 Oct 2026 16:47:32 GMT, Andy Goryachev <[email protected]> wrote:
>> Root cause: a font change in `TextArea` did not propagate to the layout (in >> its `Text` node). Another symptom was triggered by the `PrismLayout` >> reusing the stale layout cache containing runs with tabs. >> >> This fix required a headful test since it needs the real text layout. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > added test Marked as reviewed by mhanl (Reviewer). modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 269: > 267: Object font = getFontInternal(); > 268: layout.setContent(string, font); > 269: layout.setTabAdvancePolicy(getTabSize(), null); Question: Would it be more 'safe'/more sense to first set the tab advance strategy and then the content? ------------- PR Review: https://git.openjdk.org/jfx/pull/2352#pullrequestreview-5659929250 PR Review Comment: https://git.openjdk.org/jfx/pull/2352#discussion_r4383181099
