If we just use perl to set MAVEN_OPTS then it’s useless in my point of view and instead of maintaining scripts I would prefer to use the time and maintain something like this, we have to do it anyways:
https://github.com/OpenNMS/opennms/blob/HZN-635/opennms-doc/guide-development/src/asciidoc/text/dev-guide.adoc <https://github.com/OpenNMS/opennms/blob/HZN-635/opennms-doc/guide-development/src/asciidoc/text/dev-guide.adoc> They even hide a lot of things and if we depend for a specific reason on a specific Maven version then mention it in the guide above. Otherwise we tend to run ancient Maven versions cause nobody really knows and just adds barriers for Java developers. We should have the project in a shape where it should always run with latest Maven otherwise we doing something wrong. Just maintaining the perl stuff to replace a wget maven.tar.gz && tar xzf maven.tar.gz and set two variables is pretty high. Otherwise I would prefer to get bug reports or issues if something with newer Maven version fail early. Just how I see my world :) What do you think? > On Mar 22, 2016, at 9:30 AM, Markus von Rüden <m...@opennms.com> wrote: > > To me it just does not make any sense to have it in the source tree. > > You already have to have at least install git and JDK. > So why making an exception here. > > We either ship all dependencies required to compile OpenNMS, or we don’t. > Doing it only the half way doesn’t make any sense. > > In addition - as Seth already mentioned - to fully build OpenNMS the *.pl > scripts are required (due to the MAVEN_OPTS). > However the *.pl scripts use the maven version from the source tree and not > just “mvn”. > I use the mvn color plugin to see warnings and errors colored in the terminal > window. > This of course does not work with the maven version shipped with OpenNMS. > > So I definetly vote for getting it rid, as I do not see the point :) > - Markus > > >> On 22 Mar 2016, at 02:38, ro...@opennms.org wrote: >> >> Cool thank you for the info. I'll give it a shot. >> >> Sent from my iPhone >> >>> On 22 Mar 2016, at 01:14, Seth Leger <s...@opennms.org> wrote: >>> >>> Hi Ronny, >>> >>> /usr/bin/mvn on my system is just a symlink to one of my git clones' >>> /maven/bin/mvn file. I use 'mvn' all the time to run tests or build a >>> single JAR. The perl scripts just turn off all of the tests and set a >>> few environment variables (like raising the -Xmx for the JVM), they >>> don't really do much else afaik. >>> >>> If I'm in the top directory, I usually use compile.pl because most >>> builds you do across all modules will fail just because the default mvn >>> heap space is too small. You can work around this by using compile.pl or >>> setting a MVN_OPTS env variable that adds the option. >>> >>> I just tried: >>> >>> MAVEN_OPTS="-Xmx2g" mvn -DskipITs=true -Dmaven.test.skip.exec=true --fn >>> clean install >>> >>> and it ran to completion in about 10 minutes. >>> >>> -- Seth >>> >>> >>>> On 3/21/16 3:27 PM, Ronny Trommer wrote: >>>> @Seth >>>> you compile without compile.pl and assemble.pl? Can you send me the >>>> commands? >>>> I was never able to make it work without the perl scripts. I didn’t know >>>> the perl stuff is just optional. >>>> >>>> thanks >>>> >>>>> On Mar 21, 2016, at 8:23 PM, Seth Leger <s...@opennms.org> wrote: >>>>> >>>>> Hi Markus, >>>>> >>>>> I would strongly prefer to leave Maven in the source tree. This means >>>>> that users don't need to go through the (mostly manual) process of >>>>> installing maven themselves and it ensures that almost everyone is using >>>>> the same version of Maven to perform the build. >>>>> >>>>> When Maven is in the source tree, you just need to have a JDK in order >>>>> to compile all of the code. For instance, a user running OpenNMS could >>>>> clone the git repo and rebuild a single jar if necessary without >>>>> installing any other tools. >>>>> >>>>> The other dependencies (perl, makensis, postgres) are for optional >>>>> modules, release packaging, or running tests. >>>>> >>>>> Is there an advantage to getting rid of Maven? >>>>> >>>>> -- Seth >>>>> >>>>> >>>>> >>>>>> On 3/21/16 2:35 PM, Markus von Rüden wrote: >>>>>> Hey there, >>>>>> >>>>>> I would like to remove the maven binary from the OpenNMS source. >>>>>> >>>>>> Here is why: >>>>>> We already need at least the following 3rd party dependencies in order >>>>>> to compile OpenNMS (list may not be complete): >>>>>> Oracle JDK 8, Perl, Postgres, NSIS. >>>>>> >>>>>> If you have to install Maven on top of that, doesn’t really matter. >>>>>> It would be better to provide a “dev-setup” script for each platform, >>>>>> instead. >>>>>> >>>>>> What do you guys think? >>>>>> - Markus >>>>>> >>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Transform Data into Opportunity. >>>>>> Accelerate data analysis in your applications with >>>>>> Intel Data Analytics Acceleration Library. >>>>>> Click to learn more. >>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Please read the OpenNMS Mailing List FAQ: >>>>>> http://www.opennms.org/index.php/Mailing_List_FAQ >>>>>> >>>>>> opennms-devel mailing list >>>>>> >>>>>> To *unsubscribe* or change your subscription options, see the bottom of >>>>>> this page: >>>>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Transform Data into Opportunity. >>>>> Accelerate data analysis in your applications with >>>>> Intel Data Analytics Acceleration Library. >>>>> Click to learn more. >>>>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140_______________________________________________ >>>>> Please read the OpenNMS Mailing List FAQ: >>>>> http://www.opennms.org/index.php/Mailing_List_FAQ >>>>> >>>>> opennms-devel mailing list >>>>> >>>>> To *unsubscribe* or change your subscription options, see the bottom of >>>>> this page: >>>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Transform Data into Opportunity. >>>> Accelerate data analysis in your applications with >>>> Intel Data Analytics Acceleration Library. >>>> Click to learn more. >>>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 >>>> >>>> >>>> >>>> _______________________________________________ >>>> Please read the OpenNMS Mailing List FAQ: >>>> http://www.opennms.org/index.php/Mailing_List_FAQ >>>> >>>> opennms-devel mailing list >>>> >>>> To *unsubscribe* or change your subscription options, see the bottom of >>>> this page: >>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel >>> >>> >>> ------------------------------------------------------------------------------ >>> Transform Data into Opportunity. >>> Accelerate data analysis in your applications with >>> Intel Data Analytics Acceleration Library. >>> Click to learn more. >>> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 >>> _______________________________________________ >>> Please read the OpenNMS Mailing List FAQ: >>> http://www.opennms.org/index.php/Mailing_List_FAQ >>> >>> opennms-devel mailing list >>> >>> To *unsubscribe* or change your subscription options, see the bottom of >>> this page: >>> https://lists.sourceforge.net/lists/listinfo/opennms-devel >> >> ------------------------------------------------------------------------------ >> Transform Data into Opportunity. >> Accelerate data analysis in your applications with >> Intel Data Analytics Acceleration Library. >> Click to learn more. >> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 >> _______________________________________________ >> Please read the OpenNMS Mailing List FAQ: >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> opennms-devel mailing list >> >> To *unsubscribe* or change your subscription options, see the bottom of this >> page: >> https://lists.sourceforge.net/lists/listinfo/opennms-devel > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140_______________________________________________ > Please read the OpenNMS Mailing List FAQ: > http://www.opennms.org/index.php/Mailing_List_FAQ > > opennms-devel mailing list > > To *unsubscribe* or change your subscription options, see the bottom of this > page: > https://lists.sourceforge.net/lists/listinfo/opennms-devel
signature.asc
Description: Message signed with OpenPGP using GPGMail
------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
_______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel
