On Mon, Jan 21, 2013 at 1:12 PM, John <j...@clip-4-win.co.uk> wrote: > On Mon, Jan 21, 2013 at 12:11:33PM +0100, Øyvind Harboe wrote: >> Just to be clear: if you want to submit a patch to OpenOCD, then you >> do need to learn Gerrit to give your patch the best chances of review >> and approval. > > Of course a project can enforce whatever its owners/busy members/etc > decide.
It's not so much of a decision as an observation: high quality Gerrit commits get submitted in relatively short order. > >> It's pretty much a fact of life for open source that you need to show >> that you're willing to put in time if you expect that others are going >> to spend time on what you're interested in. > > Agreed. > >> If you can formulate a decent patch, then learning Gerrit will be a >> walk in the park. In this light, the list isn't terribly concerned >> about those patches that we "miss out on" because someone doesn't want >> to spend the time to learn Gerrit. Personally I view it as a noise >> filter. > > I expect lots of useful contributions (patches, new board configs etc) > simply are not sent because of this. I think that this is NOT sensible, > though it does depend on what amount of "noise" (in the sense of > unwanted/bad patches etc) there is / would be. Here? Very little... > > I think it explains the small number of items from anyone but a few > people. Everyone else is deterred completely. I don't know what's not submitted for review, because it's not submitted for review. If a patch is to make it into the master branch then it *MUST* come with an effort on the submitter or it won't be submitted. From this point of view, potentially valuable patches are indistinguishable from worthless patches. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
