On 6 March 2013 14:08, Xiaofan Chen <xiaof...@gmail.com> wrote: > On Wed, Mar 6, 2013 at 9:24 PM, Øyvind Harboe <oyvind.har...@zylin.com> wrote: >> We *do* have a fast-lane for *all* trivial patches. Anyone can go in and >> review the patch and find out if it is ready to go in and then vote for it >> to go in. >> >> You don't have to be a maintainer to review a patch. >> >> E.g. add a +1 and a comment: "this patch is trivial, it can't possibly cause >> any collateral damage, I think it should just be submitted". > > What I am talking about is not about trivial patches, for trival patches, > it seems to me usually they are actually being picked quite fast. > I am talking about those patches which are rather > isolated and not affecting other parts of OpenOCD. A new > flash driver may not be trivial. Salvador Arroyo's MIPS M4K and > PIC32MX patches may or may not be trivial. But many of them > are not affecting other parts of Openocd. So they can probably > be picked by maintainers and labeled as experimental if > necessary. I can not review them since I can not tested > them (or rather do not have a proper setup to test the > PIC32MX side and not that interested in PIC32MX myself). > But I believe there may be some users out there who would > benefit from his work. >
But this is can be a problem for maintainers aswell - we do not have all the hardware so we may well be committing a change that works for say pic32 but it may also break other mips cores. In the past we saw complaints of v4 working but v5 does not. We added gerrit so we can review and try and keep regressions down. Cheers Spen ------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
