On Wed, Mar 6, 2013 at 7:08 PM, Spencer Oliver <s...@spen-soft.co.uk> wrote: > On 6 March 2013 10:27, Franck Jullien <franck.jull...@gmail.com> wrote: >> 2013/3/6 Laurent Gauch <laurent.ga...@amontec.com>: >> >>> I like the Peter's idea, but it is not realist ! >>> As LibUsb story, OpenOCD need to respect the patch publisher and merge >>> the patches faster. If not, you do not respect the patch publisher and >>> you will lost quickly this publisher ... >>> >> >> +1 >> >> I don't want to polemicate, but Laurent is right. I was ready to be involved >> in openocd but reviewing is to long so I moved to something else.... >> > > And this sums up the issue, we do not have enough devs reviewing patches. > It takes time and with only a couple of people reviewing it is getting harder. > > OpenOCD is not like other software projects, we have a hardware > element to make sure we minimise regressions. > So review generally takes longer.
Maybe Laurent's idea is good, to categorize patches into different types and have fast track for some simpler or isolated patches. Quote what Laurent suggested: "The project is big enough to have different review process regarding which part of the structure your patch is associated. Example : SWD patch -> openocd core strucutre -> high critical review process Example : specific flash programming patch -> low critical review process" For example, Salvador Arroyo submitted many MIPS M4K and PIC32MX patches. I think many of them are not affecting other parts of Openocd. But due to the low users of Openocd for those parts, I think they are not really reviewed. On the other hand, many of them are probably safe to be merged. -- Xiaofan ------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
