Hello everybody. I'm trying to send a patch to gerrit following procedure mentioned in HACKING file. Everything is ok including checkpatch.sh run:
> ~/build/sources/openocd $ tools/checkpatch.sh >total: 0 errors, 0 warnings, 9 lines checked > >Your patch has no obvious style problems and is ready for submission. but when I'm trying to push patch, I got "remote rejected" error: > ~/build/sources/openocd $ git push review >Counting objects: 11, done. >Delta compression using up to 4 threads. >Compressing objects: 100% (6/6), done. >Writing objects: 100% (6/6), 810 bytes, done. >Total 6 (delta 5), reused 0 (delta 0) >remote: Resolving deltas: 100% (5/5) >remote: Processing changes: refs: 1, done >To ssh://[email protected]:29418/openocd.git > ! [remote rejected] HEAD -> refs/publish/master (not Signed-off-by >author/committer/uploader) >error: failed to push some refs to 'ssh://[email protected]:29418/openocd.git' Here is top lines from my commit message: topic: fix lpc2000 flash programming fail. some members of lpc2000_info structure sometimes used uninitialized (cmd51_can_64b for all LPC except LPC800 as example). Init allocated lpc2000_info structure with zeros to avoid this and similar bugs in the future. Note: maybe discarding all cmd51_can_XXXb fields and using cmd51_dst_boundary instead will be a better solution. Signed-off-by: Sergey A. Borshch <[email protected]> Change-Id: Idf116a5b0bf4ea1c39ea0ce308ec2c13bfbd4d8c # Please enter the commit message for your changes. Lines starting What's wrong with my patch and how can I fix it? -- Regards, Sergey A. Borshch mailto: [email protected] SB ELDI ltd. Riga, Latvia ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
