On 03.10.2013 18:04, Andreas Fritiofson wrote:
> What Peter said, plus the following:
>
> On Thu, Oct 3, 2013 at 3:33 PM, Sergey A. Borshch <[email protected]
> <mailto:[email protected]>> wrote:
>
>     Here is top lines from my commit message:
>     topic: fix lpc2000 flash programming fail.
>
>
> Why do you write "topic:" here? The topic of your patch might be "lpc2000", so
> write that. Something like "lpc2000: Fix flash programming fail".
Probably I misunderstood this part of HACKING file:

    Comment template, notice the short first line w/topic. The topic field
    should identify the main part or subsystem the patch touches. Check
    git log for examples.
@code
topic: Short comment
<blank line>
Longer comments over several lines, explaining (where applicable) the
reason for the patch and the general idea the solution is based on,
any major design decisions, etc...
<blank line>
Signed-off-by: ...

>
> /Andreas


-- 
Regards,
   Sergey A. Borshch            mailto: [email protected]
     SB ELDI ltd. Riga, Latvia

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to