Sergey A. Borshch wrote: > > ! [remote rejected] HEAD -> refs/publish/master (not Signed-off-by > author/committer/uploader) > >error: failed to push some refs to > 'ssh://[email protected]:29418/openocd.git' > > Here is top lines from my commit message: > topic: fix lpc2000 flash programming fail. > > some members of lpc2000_info structure sometimes used uninitialized > (cmd51_can_64b for all LPC except LPC800 as example). > Init allocated lpc2000_info structure with zeros to avoid this and similar > bugs in the future. > Note: maybe discarding all cmd51_can_XXXb fields and using > cmd51_dst_boundary > instead will be a better solution. > > Signed-off-by: Sergey A. Borshch <[email protected]> > > Change-Id: Idf116a5b0bf4ea1c39ea0ce308ec2c13bfbd4d8c > > # Please enter the commit message for your changes. Lines starting > > What's wrong with my patch and how can I fix it?
Delete the blank line between Signed-off-by and Change-Id which possibly also has trailing whitespace. Of course also make sure that your Signed-off-by address indeed fits the requirements Gerrit tells you about in the error message "not Signed-off-by author/committer/uploader". It would also be nice if you can make the commit message even more well-formed, but maybe it is fine and it was just corrupted by the email. //Peter ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
