On 31/03/14 09:27, Tim Sander wrote: > Hi Spencer >>>> On Mon, Mar 31, 2014 at 08:56:08AM +0200, Tim Sander wrote: >>>>> I am pretty confident, that the ARM_MODE_MON enum value is invalid. >>>>> at least for Cortex A9. I don't have an idea where the 26 comes from. >>>>> Have not found any references. Perhaps some Hex Decimal confusion? >>>> >>>> This should have better been sent to the devel mailing list, as many >>>> devs are not reading the users' list at all. >>> >>> Mh, as you say it. I was currently not aware that this was the users >>> list, >>> even if this is obvious from the mailing list address. >>> >>>> Can you please provide a reference (document and page number) to the >>>> official arm documentation you're reading? >>> >>> Arm Architecture Reference Manual ARMv7-a and ARMv7-R edition: >>> Table B1-1 Arm (Page B1-6,1156) column "Mode encoding" Row Monitor. >>> The Mode encoding "10110" looks pretty binary to me. And if you search for >>> 10110 this is all over the place. But there is no entry for "11010" aka >>> 26. >> >> This enum value was added in ec93209f and looking at the code the >> actual value is set to arm->core_type and never changed. >> It appears it is more of an identifier and its value is not important >> as long as it does not conflict with the other valid modes. > The enum value is used for lookup of the current cpu state. So i came across > this error while i was debugging an cortex a9 in monitor mode. Without this > patch openocd chokes with "unknown" cpu state. >> However changing it will probably make it clearer to anyone reading the >> code. Are you able to send a patch to gerrit? > Currently i don't have an Account with OpenID functionality enabled. So thats > one roadblock here. Is there an easy to set up openid server for Linux. > > Best regards > Tim >
I have pushed your patch to our review server - http://openocd.zylin.com/2081/ Spen ------------------------------------------------------------------------------ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
