On Thu, 2009-11-05 at 10:05 +0100, Øyvind Harboe wrote:
> Zach's parsing cleanup rebased automatically and compiles
> fine + passes a smoketest.
> 
> Is it ready to be pushed?

I will rebase and push it ASAP.

> Another interesting issue is whether or not we can just
> grab stuff we like from developer repositories on the
> official OpenOCD git mirror and push to master... :-)

Generally, it's best to get an explicit pull request from a developer,
but maintainers can push their work directly.

> My only concern with the parsing stuff would be if it actually ran into
> a syntax error and a code path e.g. leaked memory. Previously
> such a code path could silently do ... something that happened
> to work...

Quite the opposite; I fixed one leak that existed previously.  Further,
I reviewed the context of each change to ensure that no new problems of
this nature will appear as a result.

--Z
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to