On Fri, Nov 6, 2009 at 1:28 AM, Zach Welch <[email protected]> wrote: > On Thu, 2009-11-05 at 10:05 +0100, Øyvind Harboe wrote: >> Zach's parsing cleanup rebased automatically and compiles >> fine + passes a smoketest. >> >> Is it ready to be pushed? > > I will rebase and push it ASAP. > >> Another interesting issue is whether or not we can just >> grab stuff we like from developer repositories on the >> official OpenOCD git mirror and push to master... :-) > > Generally, it's best to get an explicit pull request from a developer, > but maintainers can push their work directly. > >> My only concern with the parsing stuff would be if it actually ran into >> a syntax error and a code path e.g. leaked memory. Previously >> such a code path could silently do ... something that happened >> to work... > > Quite the opposite; I fixed one leak that existed previously. Further, > I reviewed the context of each change to ensure that no new problems of > this nature will appear as a result.
Great! Note that there was some arm11 code that went in that doesn't have the new parsing code. I think it was only two-three locations so that's easily fixed(before or after your commit). -- Øyvind Harboe http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
