On Mon, Jun 6, 2011 at 9:32 AM, Michael Schwingen
<rincewind at discworld.dascon.de
<https://lists.berlios.de/mailman/listinfo/openocd-development>> wrote:
>/ Am 06/06/2011 09:20 AM, schrieb Yegor Yefremov:
/>>/ Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com
<https://lists.berlios.de/mailman/listinfo/openocd-development>>
/>>/
/>>/ ---
/>>/ tcl/interface/jtagkey2.cfg | 7 ++-----
/>>/ tcl/interface/jtagkey2p.cfg | 7 ++-----
/>>/ 2 files changed, 4 insertions(+), 10 deletions(-)
/>>/
/>>/ Index: b/tcl/interface/jtagkey2.cfg
/>>/ ===================================================================
/>>/ --- a/tcl/interface/jtagkey2.cfg
/>>/ +++ b/tcl/interface/jtagkey2.cfg
/>>/ @@ -4,8 +4,5 @@
/>>/ # http://www.amontec.com/jtagkey2.shtml
/>>/ #
/>>/
/>>/ -interface ft2232
/>>/ -ft2232_device_desc "Amontec JTAGkey-2"
/>>/ -ft2232_layout jtagkey
/>>/ -ft2232_vid_pid 0x0403 0xCFF8
/>>/ -
/>>/ +# The JTAGkey2 uses exactly the same config as the JTAGkey.
/>>/ +source [find interface/jtagkey.cfg]
/>>/ Index: b/tcl/interface/jtagkey2p.cfg
/>>/ ===================================================================
/>>/ --- a/tcl/interface/jtagkey2p.cfg
/>>/ +++ b/tcl/interface/jtagkey2p.cfg
/>>/ @@ -4,8 +4,5 @@
/>>/ # http://www.amontec.com/jtagkey2p.shtml
/>>/ #
/>>/
/>>/ -interface ft2232
/>>/ -ft2232_device_desc "Amontec JTAGkey-2P"
/>>/ -ft2232_layout jtagkey
/>>/ -ft2232_vid_pid 0x0403 0xCFF8
/>>/ -
/>>/ +# The JTAGkey2P uses exactly the same config as the JTAGkey.
/>>/ +source [find interface/jtagkey.cfg]
/>/ Hi,
/>/
/>/ this patch seems to remove the two different ft2232_device_desc strings.
/>/ Are these unused?
/>/
/>/ If not, I don't understand how this is supposed to work.
/>/
/>/ If the devices really can share one config file, then *one* generic file
/>/ should remain, and the others should be deleted.
/
I see your point. This won't function because
ftdi_usb_open_desc_index() makes strncmp() and the strings won't
match. So the patch was wrong. Sorry for the noise.
The only question is, what description has jtagkey-tiny "Amontec
JTAGkey" or "Amontec JTAGkey-tiny"?
The Amontec JTAGkey Tiny comes with the same description string as the
"Amontec JTAGkey".
The Amontec JTAGkey-2 Tiny will receive the same description string as
"Amontec JTAGkey-2".
The Amontec JTAGkey-3 and Amontec JTAGkey-3 Tiny (introducing SWD
interface + SWO trace ) will have description string as "Amontec JTAGkey-3"
...
Yegor
Sebastien is ready to come with some other patches making one jtagkey
configuration file generic for all Amontec JTAGkey dongles, with d2xx
driver and libusb driver on windows 32bits 64bits and linux 32bits and
64bits ...
But we are is still waiting on the merge of his first patch concerning
the ft2232 open / close , init / deinit processes ...
Regarding his patch, I am a bit worry to see any objective comments, as
if his patch comment was read in diagonal, or never read... The
maintainers ask for patch + patch comment, but nobody read the Sebastien
patch comment !!!
This patch is really nice and allows to decouple the how-to open the
ft2232 handle and how-to initialize / deinitialize a specific layout,
and make sure to free memory ... This is resolved by splitting some
functions.
If our ft2232.c patches are not merged quickly, Amontec Team will
certainly come with a new specific jtagkey.c API driver instead of the
ft2232.c JTAG driver.
The advantage with a specific Amontec JTAGkey API driver in openocd,
will be to see our patches merged in the minute, instead to wait 1 to 2
months ... also the ft2232.c will still be usable for the JTAGkey.
We will wait the end of the week ...
Regards,
Laurent
http://www.amontec.com
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
