Craig: First, let me thank you for your contribution. I'm certain that many folk will be pleased to see a scenario that does work.
Second, I don't want you rewarded for your work by being slammed with support issues. a. the Makefile for the usc-coded requires a minor modification to make it work with a standard svn trunk install of OpenPBX (Callweaver). The OPBXINC should be /usr/local/include/openpbx; alternatively if you want to use the original source tree, perhaps a comment suggesting that the OPBXINC should be modified to reflect the path of the include directory of the source tree. b. the g729b.diff patch only works against the openpbx-trunk - frankly I think that's completely appropriate but I am concerned that you're going to get a bunch of mail indicating that the user couldn't make it work using the "stable" branch. This could be mitigated by a simple notice on your instructions. c. You may want to SCREAM a little louder on your download page that this is NOT an indemnified g.729 solution. Finally, I'm concerned for the legal safety of ZettaServe. Y'all are promoting the download of a "licensed" Intel IPP5 runtime library and providing a source to compile against. I'm not a legal expert... but I'm pretty certain that the distribution of license suggests that ZettaServe is suppose to deliver binary executables or "finished product". For your own sake please double-double that... I don't want you folks to be rewarded with a law suit. Runtime comments - 1. It works! 2. I've not yet performed any specific throughput testing but will and I'll report on it soon. At first glance, however, the solution seems to have a higher translation cost than the Digium license and the IPP4.1.2 sample provided by ReadyTechnology (patched by Sam Bingner). My "first glance" was to perform a show translation from the openpbx command line. Craig Guy wrote: > > I would like to apologise for the errors in the usc-codec.tar.gz made > available for download from > http://www.zettaserve.com/default.asp?catid=78. The insertion of the > copyright statement wasn’t checked properly and one of the path > parameters in the Makefile was specified incorrectly. > > The updated usc-codecs.tar.gz should now compile cleanly without > modification on a system where openpbx source is in > /usr/src/openpbx-trunk and the default installation directories are > used. It has now been test compiled on a Centos 4.4 box with kernel > 2.6.20 and openpbx trunk #2597. If it doesn’t compile for you then let > me know. > > The ZettaServe copyright statement and license for the code is > reproduced below: > > /* Copyright (c) 2007, ZettaServe Pty Ltd > > * All rights reserved. > > * > > * Redistribution and use in source and binary forms, with or without > > * modification, are permitted provided that the following conditions > are met: > > * * Redistributions of source code must retain the above copyright > > * notice, this list of conditions and the following disclaimer. > > * * Redistributions in binary form must reproduce the above copyright > > * notice, this list of conditions and the following disclaimer in the > > * documentation and/or other materials provided with the distribution. > > * * Neither the name of the ZettaServe nor the > > * names of its contributors may be used to endorse or promote products > > * derived from this software without specific prior written permission. > > * > > * THIS SOFTWARE IS PROVIDED BY ZETTASERVE ``AS IS'' AND ANY > > * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > IMPLIED > > * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE > > * DISCLAIMED. IN NO EVENT SHALL ZETTASERVE BE LIABLE FOR ANY > > * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > DAMAGES > > * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR > SERVICES; > > * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER > CAUSED AND > > * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, > OR TORT > > * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE > USE OF THIS > > * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > */ > > *From:* [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] *On Behalf Of *Craig Guy > *Sent:* Wednesday, 18 April 2007 6:50 PM > *To:* [email protected] > *Subject:* [Openpbx-dev] G729 Licensing thread > > Hi, I noticed this thread and wanted to respond to it. > > The company I work for (ZettaServe, www.zettaserve.com > <http://www.zettaserve.com>) has working, though work-in-progress > G729a and G729ab codec for OpenPBX (with support and patches for VAD, > silence suppression and CNG) This codec is based on IPP 5.1 and is > written against trunk. G729a should be suitable for iax2, h323, sip > etc. At this time G729ab support is only for SIP. We should be > announcing it properly to this list within about a week. But for now > preliminary instructions and code can be found at > http://www.zettaserve.com/default.asp?catid=78, the license for the > ZettaServe contributions are public domain. > > Craig > _______________________________________________ Openpbx-dev mailing list [email protected] http://lists.openpbx.org/mailman/listinfo/openpbx-dev
