On Thu, Apr 26, 2012 at 10:28 AM, Jeremy Bennett <[email protected]> wrote: > On Wed, 2012-04-25 at 13:46 +0200, Peter Gavin wrote: >> Hi, >> >> This patch kills processes in the or1ksim testsuite that timeout, >> instead of letting them run forever and requiring a manual kill >> command from the shell. > > Hi Pete, > > I've never come across this problem with the Or1ksim tests, so didn't > spot the omission. Which test do you have timing out?
At the moment, all the tests work fine. But while I was modifying the simulator about a month ago I had some tests that would go into a loop, and never terminate, so I added that code so I wouldn't have to clean up the processes manually. > > I don't think you need the "kill". Just closing the current connection > will do that anyway. > > close > > From the expect manual page: > > "... close usually suffices to kill the process as well." > > You would only need to use your approach if this didn't work, but in > that case I would expect you to be using "kill -KILL". > Yeah, that's a good point. I can't remember now if I added the kill because close wasn't enough on its own. Close by itself is probably ok. -Pete _______________________________________________ OpenRISC mailing list [email protected] http://lists.openrisc.net/listinfo/openrisc
