On Thu, 2012-04-26 at 11:58 +0200, Peter Gavin wrote: > On Thu, Apr 26, 2012 at 10:28 AM, Jeremy Bennett
> > I've never come across this problem with the Or1ksim tests, so didn't > > spot the omission. Which test do you have timing out? > > At the moment, all the tests work fine. But while I was modifying the > simulator about a month ago I had some tests that would go into a > loop, and never terminate, so I added that code so I wouldn't have to > clean up the processes manually. Hi Pete, Thanks for spotting the omission. It will make the tool more robust to development going forward. > > I don't think you need the "kill". Just closing the current connection > > will do that anyway. > > > > close > > > > From the expect manual page: > > > > "... close usually suffices to kill the process as well." > > > > You would only need to use your approach if this didn't work, but in > > that case I would expect you to be using "kill -KILL". > > > > Yeah, that's a good point. I can't remember now if I added the kill > because close wasn't enough on its own. Close by itself is probably > ok. Please commit to SVN (I assume you'll update the ChangeLog and configure.ac version dates and check "make distcheck" works). Thanks, Jeremy -- Tel: +44 (1590) 610184 Cell: +44 (7970) 676050 SkypeID: jeremybennett Email: [email protected] Web: www.embecosm.com _______________________________________________ OpenRISC mailing list [email protected] http://lists.openrisc.net/listinfo/openrisc
