Summary: amfnd: queue PG track action msgs [#2115] 
Review request for Trac Ticket(s): 2115 
Peer Reviewer(s): AMF devs 
Affected branch(es): all
Development branch: default 

Impacted area       Impact y/n
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y  
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n

Comments (indicate scope for each "y" above):

changeset d2810a626b556745d1392e93804be57babc5bf6a
Author: Gary Lee <>
Date:   Thu, 13 Oct 2016 09:41:32 +1100

        amfnd: queue PG track action msgs [#2115]

        After SC absence, active amfd will reject messages from 'veteran' amfnds
        until its local amfnd has started. During this period, if a PG track 
        msg is sent and rejected by amfd, it will cause the sending amfnd to 
        sync with amfd. So we should also queue this message to be re-sent.

Complete diffstat:
 osaf/services/saf/amf/amfnd/ |  8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

Testing Commands:
Load an application that uses PG tracking onto PL-3 
Turn off SCs
Turn on SCs
During the SC recovery period (but before amfnd on active SC comes up), restart 
the application

Testing, Expected Results:
Some "avd_msg_sanity_chk: invalid msg id" messages should be seen on active SC, 
will recover after retransmission

Conditions of Submission:
ack from an AMF dev

Arch      Built     Started    Linux distro
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y 
powerpc     n          n
powerpc64   n          n

Reviewer Checklist:
[Submitters: make sure that your review doesn't trigger any checkmarks!]

Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.

Check out the vibrant tech community on one of the world's most 
engaging tech sites,!
Opensaf-devel mailing list

Reply via email to