Hi Mohan,
Ack for this patch with a minor comment. Thanks.
Regards, Vu
> -----Original Message-----
> From: Mohan Kanakam <mo...@hasolutions.in>
> Sent: Thursday, November 1, 2018 3:28 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
> <mo...@hasolutions.in>
> Subject: [PATCH 2/3] imm: add new test case of API saImmOmDispatch() of
> apitest [#2951]
>
> ---
> src/imm/apitest/management/test_saImmOmDispatch.c | 72
> ++++++++++++++++++++++
> .../apitest/management/test_saImmOmInitialize.c | 35 +++++++++++
> 2 files changed, 107 insertions(+)
>
> diff --git a/src/imm/apitest/management/test_saImmOmDispatch.c
> b/src/imm/apitest/management/test_saImmOmDispatch.c
> index 3648a95..0ab9885 100644
> --- a/src/imm/apitest/management/test_saImmOmDispatch.c
> +++ b/src/imm/apitest/management/test_saImmOmDispatch.c
> @@ -52,3 +52,75 @@ void saImmOmDispatch_04(void)
> test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
> safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> }
> +
> +void saImmOmDispatch_05(void)
> +{
> + rc = saImmOmDispatch(immOmHandle, SA_DISPATCH_ONE);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmDispatch_06(void)
> +{
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + immutil_saImmOmFinalize(immOmHandle);
> + rc = saImmOmDispatch(immOmHandle, SA_DISPATCH_ONE);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmDispatch_07(void)
> +{
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + rc = saImmOmDispatch(immOmHandle, SA_DISPATCH_BLOCKING);
> + test_validate(rc, SA_AIS_OK);
> + safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> +}
> +
> +void saImmOmDispatch_08(void)
> +{
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + rc = saImmOmDispatch(-1, SA_DISPATCH_ALL);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> + safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> +}
> +
> +void saImmOmDispatch_09(void)
> +{
> + rc = saImmOmDispatch(immOmHandle, SA_DISPATCH_ALL);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmDispatch_10(void)
> +{
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + immutil_saImmOmFinalize(immOmHandle);
> + rc = saImmOmDispatch(immOmHandle, SA_DISPATCH_ALL);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmDispatch_11(void)
> +{
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + rc = saImmOmDispatch(-1, SA_DISPATCH_BLOCKING);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> + safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> +}
> +
> +void saImmOmDispatch_12(void)
> +{
> + rc = saImmOmDispatch(immOmHandle, SA_DISPATCH_BLOCKING);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmDispatch_13(void)
> +{
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + immutil_saImmOmFinalize(immOmHandle);
> + rc = saImmOmDispatch(immOmHandle, SA_DISPATCH_BLOCKING);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> diff --git a/src/imm/apitest/management/test_saImmOmInitialize.c
> b/src/imm/apitest/management/test_saImmOmInitialize.c
> index 2dca5da..b17ab86 100644
> --- a/src/imm/apitest/management/test_saImmOmInitialize.c
> +++ b/src/imm/apitest/management/test_saImmOmInitialize.c
> @@ -309,6 +309,15 @@ extern void saImmOmDispatch_01(void);
> extern void saImmOmDispatch_02(void);
> extern void saImmOmDispatch_03(void);
> extern void saImmOmDispatch_04(void);
> +extern void saImmOmDispatch_05(void);
> +extern void saImmOmDispatch_06(void);
> +extern void saImmOmDispatch_07(void);
> +extern void saImmOmDispatch_08(void);
> +extern void saImmOmDispatch_09(void);
> +extern void saImmOmDispatch_10(void);
> +extern void saImmOmDispatch_11(void);
> +extern void saImmOmDispatch_12(void);
> +extern void saImmOmDispatch_13(void);
> extern void saImmOmFinalize_01(void);
> extern void saImmOmFinalize_02(void);
> extern void saImmOmThreadInterference_01(void);
> @@ -369,6 +378,32 @@ __attribute__((constructor)) static void
> saImmOmInitialize_constructor(void)
> test_case_add(
> 1, saImmOmDispatch_04,
> "saImmOmDispatch - SA_AIS_ERR_INVALID_PARAM - invalid
> dispatchFlags");
> + test_case_add(
> + 1, saImmOmDispatch_05,
> + "saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized
> handle SA_DISPATCH_ONE");
[Vu] Typo uninitilized? Also check it in following printouts.
> + test_case_add(
> + 1, saImmOmDispatch_06,
> + "saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle
> SA_DISPATCH_ONE");
> + test_case_add(1, saImmOmDispatch_07,
> + "saImmOmDispatch - SA_AIS_OK
> SA_DISPATCH_BLOCKING");
> + test_case_add(
> + 1, saImmOmDispatch_08,
> + "saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - invalid handle
> SA_DISPATCH_ALL");
> + test_case_add(
> + 1, saImmOmDispatch_09,
> + "saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized
> handle SA_DISPATCH_ALL");
> + test_case_add(
> + 1, saImmOmDispatch_10,
> + "saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle
> SA_DISPATCH_ALL");
> + test_case_add(
> + 1, saImmOmDispatch_11,
> + "saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - invalid handle
> SA_DISPATCH_BLOCKING");
> + test_case_add(
> + 1, saImmOmDispatch_12,
> + "saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized
> handle SA_DISPATCH_BLOCKING");
> + test_case_add(
> + 1, saImmOmDispatch_13,
> + "saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle
> SA_DISPATCH_BLOCKING");
>
> test_case_add(1, saImmOmFinalize_01, "saImmOmFinalize -
> SA_AIS_OK");
> test_case_add(
> --
> 2.7.4
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
